Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rector/rector requirement from ^0.16 to ^0.17 #265

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 1, 2023

Updates the requirements on rector/rector to permit the latest version.

Release notes

Sourced from rector/rector's releases.

Released Rector 0.17

Preparing for Rector 1.0

In this release, we focus on architecture improvements before reaching Rector 1.0. We want to lower the memory usage and make Rector run faster.

This include removing next/previous nodes - this will most likely not affect you, as Rector rules were upgraded, but if you do you use them, switch to StmtsAwareInterface instead

We follow PHPStan 1.6 move from April 2022, where you can learn more: https://phpstan.org/blog/preprocessing-ast-for-custom-rules

  • Replace NodeConnectingVisitor with ParentConnectingVisitor (#3900)

To see how to refactor to StmtsAwareInterface, check these PRs:

  • Remove NEXT_NODE dependency in ChangeAndIfToEarlyReturnRector, narrow to only closed scope function likes (#3913)
  • Remove NEXT_NODE from SimplifyIfReturnBoolRector (#3915)
  • [DeadCode] Remove next attribute on RemoveUnusedVariableAssignRector ([#3917](https://github.com/rectorphp/
  • [CodingStyle] Refactor CatchExceptionNameMatchingTypeRector to use StmtsAwareInterface (#3788)

Add/remove nodes directly 👍

The next improvement focuses on explicit node adding/removal. Thanks to StmtsAwareInterface we can add nodes directly. This makes Rector refactor() method contain all the code you need.

  • Cleanup usage of NodesToAddCollector, return nodes directly instead (#4003)
  • Cleanup removeNodeFromStatements(), removeArg(), removeParam(), removeStmt() methods and remove nodes directly (#4012)
  • Remove unused addNodeAfterNode(), return nodes instead (#4023)
  • Remove unused method addNodesBeforeNode() (#4024)

New Features 🥳

  • [PHP 7.0] Add IfIssetToCoalescingRector (#3878)
  • Support attributes in RemoveFinalFromEntityRector (#3727), Thanks @​alexndlm!
  • Add SwapMethodCallArgumentsRector (#3726), Thanks @​gaydamakha!
  • [CodeQuality] Add CleanupUnneededNullsafeOperatorRector (#3767)
  • Make ReturnNeverTypeRector work with type declaration, add it to PHP 8.1 set (#3852)
  • [TypeDeclaration] Add BoolReturnTypeFromStrictScalarReturnsRector (#3898)
  • Make ChangeGlobalVariablesToPropertiesRector add properties directly, remove Nette inject methods (#3957)
  • Utilize MinPhpVersionInterface in more rules (#3752), Thanks @​staabm!
  • Dump dependency container and re-use it - 35% faster test-suite (#3809), Thanks @​staabm!
  • Defer type-resolving in RemoveJustPropertyFetchRector (#3761), Thanks @​staabm!

Bugfixes 🐛

  • [TypeDeclaration] Skip Arg unpack on AddMethodCallBasedStrictParamTypeRector (#3787)

... (truncated)

Commits
  • d8da002 Rector 0.17.0
  • a4b4c3a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • 9a2931c Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • bfd8f1a Updated Rector to commit bdc2fc99631f67eeb2d96e2cf0906279c2561c9a
  • b655a25 Updated Rector to commit 81e8c74b0ea2a107db681ee21c13925837b84abc
  • a31c14f Updated Rector to commit 98fa6b51c4114010cb45c7f07ad96256430bf605
  • c0ad822 Updated Rector to commit 227186b39430fee40e5c6ba5ff7261700c9d5031
  • c8207cf Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • f7d04bd Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • 089eca6 Updated Rector to commit b84fe9524aa20e200f743f13f6925d93225c6280
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.16.0...0.17.0)

---
updated-dependencies:
- dependency-name: rector/rector
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jun 1, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jun 1, 2023

PR Summary

  • Updated Rector Version
    Upgraded the Rector dependency from version 0.16 to 0.17, enabling access to new features and improvements.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0ebe2c7) 87.73% compared to head (f15abc8) 87.73%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #265   +/-   ##
=========================================
  Coverage     87.73%   87.73%           
  Complexity      597      597           
=========================================
  Files             7        7           
  Lines          1329     1329           
=========================================
  Hits           1166     1166           
  Misses          163      163           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 18, 2023

Superseded by #270.

@dependabot dependabot bot closed this Aug 18, 2023
@dependabot dependabot bot deleted the dependabot/composer/rector/rector-tw-0.17 branch August 18, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants