Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw UnknownPropertyException when setting unknown property #275

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 13, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Dec 13, 2023

PR Summary

  • Enhancements in Property Setting
    In technical language, a safeguard has been added in BaseActiveRecordTrait.php to ensure that data properties being set are recognized. Simply put, this means that the system will now throw an error if one tries to set a property it doesn't recognize. This is a significant move for preventing possible issues that can occur by setting unfamiliar properties.

  • Test Additions for Unknown Properties
    For ensuring our updated safeguard works effectively, a control has been added in ActiveRecordTest.php. In simpler terms, a new test case is added to check if the system properly alerts when someone tries to set a property that the system doesn't recognize. This is an important step in validating our new safety enhancement and will help us to maintain the software health in terms of unexpected property alterations.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c6691) 87.75% compared to head (88cc62f) 87.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #275      +/-   ##
============================================
+ Coverage     87.75%   87.77%   +0.01%     
  Complexity      598      598              
============================================
  Files             7        7              
  Lines          1331     1333       +2     
============================================
+ Hits           1168     1170       +2     
  Misses          163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark
Copy link
Member

samdark commented Dec 13, 2023

Good one!

@Tigrov Tigrov merged commit 813da82 into master Dec 16, 2023
51 of 53 checks passed
@Tigrov Tigrov deleted the throw-exception-when-setting-unknown-property branch December 16, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants