Update the comments of the method createQueryTo in ActiveRecordFactory so that the IDE can automatically identify the specific class of ActiveRecord #280

niqingyang · 2023-12-19T13:35:40Z

Q	A
Is bugfix?	✔️/❌
New feature?	✔️/❌
Breaks BC?	✔️/❌
Fixed issues	comma-separated list of tickets # fixed by the PR, if any

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

This reverts commit baf1889.

This reverts commit 0af5333.

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

…y so that the IDE can automatically identify the specific class of ActiveRecord

what-the-diff · 2023-12-19T13:35:53Z

PR Summary

Introduction of a Generic Type Parameter
A modification has happened to the 'createAR' function. Now, users can input different kinds of data, providing more flexibility and versatility with our user's needs. This change allows the method to handle different data types dynamically.

codecov · 2023-12-19T13:36:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d9864b) 87.70% compared to head (71b35f2) 87.70%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #280   +/-   ##
=========================================
  Coverage     87.70%   87.70%           
  Complexity      595      595           
=========================================
  Files             7        7           
  Lines          1326     1326           
=========================================
  Hits           1163     1163           
  Misses          163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…y so that the IDE can automatically identify the specific class of ActiveRecord

Tigrov

Also need to check that tests passed

src/ActiveRecordFactory.php

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

…y so that the IDE can automatically identify the specific class of ActiveRecord

niqingyang · 2024-01-02T09:35:21Z

Also need to check that tests passed

🎉 It has been tests passed

src/ActiveQuery.php

src/ActiveRecordFactory.php

src/BaseActiveRecord.php

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

src/ActiveQuery.php

src/BaseActiveRecord.php

Tigrov

👍

niqingyang and others added 26 commits December 9, 2023 16:50

implement the interface ArrayableInterface for BaseActiveRecord

12c3300

implement the interface ArrayableInterface for BaseActiveRecord

be499a5

implement the interface ArrayableInterface for BaseActiveRecord

3988dcc

implement the interface ArrayableInterface for BaseActiveRecord

424f841

implement the interface ArrayableInterface for BaseActiveRecord

b64dde5

implement the interface ArrayableInterface for BaseActiveRecord

0f680fe

implement the interface ArrayableInterface for BaseActiveRecord

594a222

implement the interface ArrayableInterface for BaseActiveRecord

08711a6

implement the interface ArrayableInterface for BaseActiveRecord

cb9db0e

implement the interface ArrayableInterface for BaseActiveRecord

044755d

implement the interface ArrayableInterface for BaseActiveRecord

fa7c4cb

Update src/BaseActiveRecord.php

0af5333

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/ActiveRecordInterface.php

baf1889

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Revert "Update src/ActiveRecordInterface.php"

b479a12

This reverts commit baf1889.

Revert "Update src/BaseActiveRecord.php"

0af32f1

This reverts commit 0af5333.

implement the interface ArrayableInterface for BaseActiveRecord

c84a97d

implement the interface ArrayableInterface for BaseActiveRecord

2b82b2b

Update tests/Driver/Oracle/ActiveRecordTest.php

32cc7b4

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update tests/Driver/Pgsql/ActiveRecordTest.php

8583269

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

implement the interface ArrayableInterface for BaseActiveRecord

e299dfa

implement the interface ArrayableInterface for BaseActiveRecord

1f86104

implement the interface ArrayableInterface for BaseActiveRecord

43f615b

implement the interface ArrayableInterface for BaseActiveRecord

418be7d

implement the interface ArrayableInterface for BaseActiveRecord

564e019

Merge branch 'yiisoft:master' into master

20e8962

Update the comments of the method createQueryTo in ActiveRecordFactor…

a5ab133

…y so that the IDE can automatically identify the specific class of ActiveRecord

niqingyang added 2 commits December 19, 2023 21:37

Update the comments of the method createQueryTo in ActiveRecordFactor…

ae57733

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

480c0e1

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

64b5b31

…y so that the IDE can automatically identify the specific class of ActiveRecord

samdark approved these changes Dec 20, 2023

View reviewed changes

samdark requested review from vjik and Tigrov December 20, 2023 12:13

xepozz approved these changes Dec 21, 2023

View reviewed changes

Tigrov requested changes Dec 22, 2023

View reviewed changes

src/ActiveRecordFactory.php Outdated Show resolved Hide resolved

niqingyang and others added 9 commits December 28, 2023 01:07

Update src/ActiveRecordFactory.php

d531911

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update the comments of the method createQueryTo in ActiveRecordFactor…

c62cd19

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

f488291

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

8430f4a

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

491e8f2

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

6ce2ce3

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

f3158eb

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

7950258

…y so that the IDE can automatically identify the specific class of ActiveRecord

Update the comments of the method createQueryTo in ActiveRecordFactor…

919ccb1

…y so that the IDE can automatically identify the specific class of ActiveRecord

Tigrov requested changes Jan 2, 2024

View reviewed changes

niqingyang and others added 9 commits January 3, 2024 10:12

Update src/ActiveQuery.php

2991192

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/ActiveRecordFactory.php

ec3a466

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

236c7af

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

15e9484

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

380e4dc

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

80b1a83

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

040a83a

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

ff9f101

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Update src/BaseActiveRecord.php

801b80a

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>

Tigrov reviewed Jan 3, 2024

View reviewed changes

src/ActiveQuery.php Outdated Show resolved Hide resolved

src/BaseActiveRecord.php Outdated Show resolved Hide resolved

src/BaseActiveRecord.php Outdated Show resolved Hide resolved

Apply suggestions from code review

71b35f2

Tigrov approved these changes Jan 3, 2024

View reviewed changes

Tigrov merged commit e32fa0d into yiisoft:master Jan 3, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the comments of the method createQueryTo in ActiveRecordFactory so that the IDE can automatically identify the specific class of ActiveRecord #280

Update the comments of the method createQueryTo in ActiveRecordFactory so that the IDE can automatically identify the specific class of ActiveRecord #280

niqingyang commented Dec 19, 2023

what-the-diff bot commented Dec 19, 2023

codecov bot commented Dec 19, 2023 •

edited

Loading

Tigrov left a comment

niqingyang commented Jan 2, 2024

Tigrov left a comment

Update the comments of the method createQueryTo in ActiveRecordFactory so that the IDE can automatically identify the specific class of ActiveRecord #280

Update the comments of the method createQueryTo in ActiveRecordFactory so that the IDE can automatically identify the specific class of ActiveRecord #280

Conversation

niqingyang commented Dec 19, 2023

what-the-diff bot commented Dec 19, 2023

PR Summary

codecov bot commented Dec 19, 2023 • edited Loading

Codecov Report

Tigrov left a comment

Choose a reason for hiding this comment

niqingyang commented Jan 2, 2024

Tigrov left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 19, 2023 •

edited

Loading