-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the comments of the method createQueryTo in ActiveRecordFactory so that the IDE can automatically identify the specific class of ActiveRecord #280
Conversation
niqingyang
commented
Dec 19, 2023
Q | A |
---|---|
Is bugfix? | ✔️/❌ |
New feature? | ✔️/❌ |
Breaks BC? | ✔️/❌ |
Fixed issues | comma-separated list of tickets # fixed by the PR, if any |
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
This reverts commit baf1889.
This reverts commit 0af5333.
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
…y so that the IDE can automatically identify the specific class of ActiveRecord
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
=========================================
Coverage 87.70% 87.70%
Complexity 595 595
=========================================
Files 7 7
Lines 1326 1326
=========================================
Hits 1163 1163
Misses 163 163 ☔ View full report in Codecov by Sentry. |
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to check that tests passed
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
…y so that the IDE can automatically identify the specific class of ActiveRecord
🎉 It has been tests passed |
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍