Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $tableName property from constructor #366

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jun 25, 2024

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC? ✔️
Fixed issues #364

@Tigrov Tigrov requested a review from a team June 25, 2024 08:08
@Tigrov Tigrov added the status:code review The pull request needs review. label Jun 25, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (e3c7c6e) to head (825a647).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #366   +/-   ##
=========================================
  Coverage     86.35%   86.35%           
+ Complexity      598      597    -1     
=========================================
  Files            13       14    +1     
  Lines          1407     1407           
=========================================
  Hits           1215     1215           
  Misses          192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit ccca25f into master Jul 1, 2024
57 checks passed
@Tigrov Tigrov deleted the remove-tableName-property branch July 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants