Make ActiveQuery::getARClassName() private
#367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tigrov
commented
Jun 25, 2024
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fixed issues | - |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
=========================================
Coverage 86.35% 86.35%
Complexity 598 598
=========================================
Files 13 13
Lines 1407 1407
=========================================
Hits 1215 1215
Misses 192 192 ☔ View full report in Codecov by Sentry. |
arogachev
requested changes
Jun 25, 2024
| @@ -2671,7 +2671,7 @@ public function testARClassAsString(): void | |||
| $query = new ActiveQuery(Customer::class, $this->db); | |||
|
|
|||
| $this->assertSame($query->getARClass(), Customer::class); | |||
| $this->assertSame($query->getARClassName(), Customer::class); | |||
| $this->assertSame(Assert::invokeMethod($query, 'getARClassName'), Customer::class); | |||
There was a problem hiding this comment.
Private method is tested directly.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.