Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $db property from constructor #368

Merged
merged 24 commits into from
Jul 3, 2024
Merged

Remove $db property from constructor #368

merged 24 commits into from
Jul 3, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jun 28, 2024

Q A
Is bugfix? ✔️/❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #364

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.02%. Comparing base (ccca25f) to head (6afc4eb).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #368      +/-   ##
============================================
- Coverage     86.35%   86.02%   -0.33%     
- Complexity      597      601       +4     
============================================
  Files            14       16       +2     
  Lines          1407     1410       +3     
============================================
- Hits           1215     1213       -2     
- Misses          192      197       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
src/ConnectionProvider.php Outdated Show resolved Hide resolved
src/ConnectionProviderMiddleware.php Show resolved Hide resolved
Tigrov and others added 5 commits July 1, 2024 16:47
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
# Conflicts:
#	src/AbstractActiveRecord.php
#	src/ActiveQuery.php
#	src/ActiveRecordFactory.php
#	tests/ActiveQueryTest.php
#	tests/ActiveRecordFactoryTest.php
#	tests/Stubs/ActiveRecord/CustomerWithConstructor.php
@Tigrov Tigrov merged commit cd71945 into master Jul 3, 2024
55 of 56 checks passed
@Tigrov Tigrov deleted the remove-db-property branch July 3, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants