Refactoring

.github/workflows/benchmark.yml

@@ -0,0 +1,33 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+  push:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+name: bechmark
+
+jobs:
+  phpbench:
+    uses: yiisoft/actions/.github/workflows/phpbench.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest', 'windows-latest']
+      php: >-
+        ['8.1', '8.2']
+      report: aggregate
+

.github/workflows/build.yml

@@ -28,4 +28,4 @@ jobs:
       os: >-
         ['ubuntu-latest', 'windows-latest']
       php: >-
-        ['8.0', '8.1']
+        ['8.1', '8.2']

.github/workflows/composer-require-checker.yml

@@ -30,4 +30,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.0']
+        ['8.1']

.github/workflows/mutation.yml

@@ -26,6 +26,6 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.1']
+        ['8.2']
     secrets:
       STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}

.github/workflows/rector.yml

@@ -18,4 +18,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.0']
+        ['8.2']

.github/workflows/static.yml

@@ -28,4 +28,4 @@ jobs:
       os: >-
         ['ubuntu-latest']
       php: >-
-        ['8.0', '8.1']
+        ['8.1', '8.2']

.scrutinizer.yml

@@ -10,7 +10,7 @@ build:
 
   environment:
     php:
-      version: 8.0.18
+      version: 8.1
       ini:
         xdebug.mode: coverage
 

.styleci.yml

@@ -7,6 +7,9 @@ finder:
   exclude:
     - docs
     - vendor
+  not-name:
+    - wrong_file.php
+    - namespace.php
 
 enabled:
   - alpha_ordered_traits

README.md

@@ -9,11 +9,11 @@
 [![Latest Stable Version](https://poser.pugx.org/yiisoft/classifier/v/stable.png)](https://packagist.org/packages/yiisoft/classifier)
 [![Total Downloads](https://poser.pugx.org/yiisoft/classifier/downloads.png)](https://packagist.org/packages/yiisoft/classifier)
 [![Build status](https://github.com/yiisoft/classifier/workflows/build/badge.svg)](https://github.com/yiisoft/classifier/actions?query=workflow%3Abuild)
-[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/yiisoft/classifier/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/yiisoft/classifier/?branch=master)
-[![Code Coverage](https://scrutinizer-ci.com/g/yiisoft/classifier/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/yiisoft/classifier/?branch=master)
+[![Code Coverage](https://codecov.io/gh/yiisoft/classifier/branch/master/graph/badge.svg)](https://codecov.io/gh/yiisoft/classifier)
 [![Mutation testing badge](https://img.shields.io/endpoint?style=flat&url=https%3A%2F%2Fbadge-api.stryker-mutator.io%2Fgithub.com%2Fyiisoft%2Fclassifier%2Fmaster)](https://dashboard.stryker-mutator.io/reports/github.com/yiisoft/classifier/master)
 [![static analysis](https://github.com/yiisoft/classifier/workflows/static%20analysis/badge.svg)](https://github.com/yiisoft/classifier/actions?query=workflow%3A%22static+analysis%22)
 [![type-coverage](https://shepherd.dev/github/yiisoft/classifier/coverage.svg)](https://shepherd.dev/github/yiisoft/classifier)
+[![psalm-level](https://shepherd.dev/github/yiisoft/classifier/level.svg)](https://shepherd.dev/github/yiisoft/classifier)
 
 Classifier traverses file system to find classes by a certain criteria.
 

composer-require-checker.json

@@ -0,0 +1,15 @@
+{
+    "symbol-whitelist": [
+        "PhpToken",
+        "T_PAAMAYIM_NEKUDOTAYIM",
+        "T_NAMESPACE",
+        "T_STRING",
+        "T_CLASS",
+        "T_INTERFACE",
+        "T_TRAIT",
+        "T_ENUM",
+        "T_NS_SEPARATOR",
+        "T_NEW",
+        "T_WHITESPACE"
+    ]
+}

composer.json

@@ -30,11 +30,12 @@
         }
     ],
     "require": {
-        "php": "^8.0",
+        "php": "^8.1",
         "symfony/finder": "^5.4|^6.0|^7.1"
     },
     "require-dev": {
         "maglnet/composer-require-checker": "^4.2",
+        "phpbench/phpbench": "^1.2",
         "phpunit/phpunit": "^9.5",
         "rector/rector": "^1.0.0",
         "roave/infection-static-analysis-plugin": "^1.16",
@@ -51,6 +52,9 @@
             "Yiisoft\\Classifier\\Tests\\": "tests"
         }
     },
+    "suggest": {
+        "ext-tokenizer": "Need for TokenizerClassifier implementation"
+    },
     "config": {
         "sort-packages": true,
         "allow-plugins": {

phpbench.json

@@ -0,0 +1,12 @@
+{
+    "runner.bootstrap": "vendor/autoload.php",
+    "runner.path": "tests/Benchmark",
+    "runner.retry_threshold": 3,
+    "report.outputs": {
+        "csv_file": {
+            "extends": "delimited",
+            "delimiter": ",",
+            "file": "benchmarks.csv"
+        }
+    }
+}

rector.php

@@ -12,6 +12,10 @@
         __DIR__ . '/tests',
     ]);
 
+    $rectorConfig->skip([
+        __DIR__ . '/tests/Support/wrong_file.php',
+    ]);
+
     // register a single rule
     $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
 

src/AbstractClassifier.php

@@ -0,0 +1,93 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Classifier;
+
+use ReflectionClass;
+use Symfony\Component\Finder\Finder;
+use Yiisoft\Classifier\Filter\FilterInterface;
+
+/**
+ * Base implementation for {@see ClassifierInterface} with common filters.
+ */
+abstract class AbstractClassifier implements ClassifierInterface
+{
+    /**
+     * @var array<class-string|trait-string, ReflectionClass>
+     */
+    protected static array $reflectionsCache = [];
+
+    /**
+     * @var FilterInterface[]
+     */
+    private array $filters = [];
+    /**
+     * @var string[]
+     */
+    protected array $directories;
+
+    public function __construct(string $directory, string ...$directories)
+    {
+        $this->directories = [$directory, ...array_values($directories)];
+    }
+
+    public function withFilter(FilterInterface ...$filter): static
+    {
+        $new = clone $this;
+        array_push($new->filters, ...array_values($filter));
+
+        return $new;
+    }
+
+    /**
+     * @return iterable<class-string>
+     */
+    public function find(): iterable
+    {
+        foreach ($this->getAvailableDeclarations() as $declaration) {
+            if ($this->skipDeclaration($declaration)) {
+                continue;
+            }
+            yield $declaration;
+        }
+    }
+
+    protected function getFiles(): Finder
+    {
+        return (new Finder())
+            ->in($this->directories)
+            ->name('*.php')
+            ->sortByName()
+            ->files();
+    }
+
+    /**
+     * @param class-string|trait-string $declaration
+     */
+    private function skipDeclaration(string $declaration): bool
+    {
+        try {
+            $reflectionClass = self::$reflectionsCache[$declaration] ??= new ReflectionClass($declaration);
+        } catch (\Throwable) {
+            return true;
+        }
+
+        if ($reflectionClass->isInternal() || $reflectionClass->isAnonymous()) {
+            return true;
+        }
+
+        foreach ($this->filters as $filter) {
+            if (!$filter->match($reflectionClass)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * @return iterable<class-string|trait-string>
+     */
+    abstract protected function getAvailableDeclarations(): iterable;
+}