Skip to content

Token classifier & refactor filters #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 26, 2023
Merged

Token classifier & refactor filters #41

merged 15 commits into from
Oct 26, 2023

Conversation

@rustamwin
Copy link
Member

@rustamwin rustamwin commented Oct 20, 2023 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #39

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2db3db7) 100.00% compared to head (527cdce) 100.00%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             refactoring       #41    +/-   ##
================================================
  Coverage         100.00%   100.00%            
- Complexity            24        73    +49     
================================================
  Files                  2         8     +6     
  Lines                 60       175   +115     
================================================
+ Hits                  60       175   +115
Files Coverage Δ
src/AbstractClassifier.php 100.00% <100.00%> (ø)
src/Filter/ClassAttributes.php 100.00% <100.00%> (ø)
src/Filter/ClassImplements.php 100.00% <100.00%> (ø)
src/Filter/SubclassOf.php 100.00% <100.00%> (ø)
src/Filter/TargetAttribute.php 100.00% <100.00%> (ø)
src/NativeClassifier.php 100.00% <100.00%> (ø)
src/ReflectionFile.php 100.00% <100.00%> (ø)
src/TokenizerClassifier.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustamwin rustamwin marked this pull request as draft October 20, 2023 11:33
@xepozz
Copy link
Member

xepozz commented Oct 20, 2023

Please don't forget to compare benchmarks

@rustamwin rustamwin mentioned this pull request Oct 20, 2023
Open
@rustamwin rustamwin marked this pull request as ready for review October 22, 2023 13:54
@rustamwin rustamwin requested a review from a team October 22, 2023 13:55
@rustamwin rustamwin added the status:code review The pull request needs review. label Oct 22, 2023
@rustamwin
Copy link
Member Author

rustamwin commented Oct 22, 2023

ℹ️ The classifier now also finds interfaces, traits and enums.

@samdark
Copy link
Member

samdark commented Oct 23, 2023

@rustamwin #41 (comment)?

@rustamwin
Copy link
Member Author

rustamwin commented Oct 23, 2023

@rustamwin #41 (comment)?

I will do it within 1-2 days.

@rustamwin rustamwin merged commit 76f5f2f into refactoring Oct 26, 2023
@rustamwin rustamwin deleted the token-classifier branch October 26, 2023 14:36
@rustamwin
Copy link
Member Author

rustamwin commented Oct 27, 2023

Benchmark results here: #38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rustamwin @xepozz @samdark @StyleCIBot