Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trim, LeftTrim and RightTrim parameter attributes #79

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Add Trim, LeftTrim and RightTrim parameter attributes #79

merged 3 commits into from
Apr 3, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 3, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Fix #78

@vjik vjik requested a review from a team April 3, 2024 06:34
@vjik vjik added the status:code review The pull request needs review. label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c51e692) to head (8fc7384).

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #79   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       234       258   +24     
===========================================
  Files             31        37    +6     
  Lines            613       667   +54     
===========================================
+ Hits             613       667   +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 4e57b93 into master Apr 3, 2024
19 checks passed
@vjik vjik deleted the trim branch April 3, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Trim attribute
3 participants