Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grpc/grpc dependency #73

Closed
vjik opened this issue Aug 7, 2023 · 1 comment
Closed

Remove grpc/grpc dependency #73

vjik opened this issue Aug 7, 2023 · 1 comment
Labels
status:ready for adoption Feel free to implement this issue.
Milestone
3.0.0

Comments

@vjik
Copy link
Member

vjik commented Aug 7, 2023

This dependency is optional and must keep in suggest section only.

But for tests need add grpc/grpc and ext-grpc to require-dev.

Also need add information about suggest packages to readme.
@vjik vjik added this to the 3.0.0 milestone Aug 7, 2023
@vjik vjik changed the title Remove grpc/grpc dependency Remove grpc/grpc dependency Aug 7, 2023
@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Aug 11, 2023
s1lver added a commit that referenced this issue Aug 22, 2023
@s1lver
(#73) Moved grpc/grpc dependency
3953e55
@s1lver s1lver mentioned this issue Aug 22, 2023
Merged
vjik pushed a commit that referenced this issue Feb 22, 2024
@s1lver
(#73) Moved grpc/grpc dependency (#76)
8abdab5
@vjik
Copy link
Member Author

vjik commented Feb 22, 2024

Done by #76

@vjik vjik closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@samdark @vjik