Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#73) Moved grpc/grpc dependency #76

Merged
merged 8 commits into from
Feb 22, 2024
Merged

(#73) Moved grpc/grpc dependency #76

merged 8 commits into from
Feb 22, 2024

Conversation

s1lver
Copy link
Member

@s1lver s1lver commented Aug 22, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #73

@s1lver s1lver added the type:enhancement Enhancement label Aug 22, 2023
@s1lver s1lver requested a review from vjik August 22, 2023 12:23
@what-the-diff
Copy link

what-the-diff bot commented Aug 22, 2023

PR Summary

  • Ignoring PHPUnit cache files
    The team included PHPUnit's result cache files in the .gitignore file. This prevents redundant files from being tracked in the git repository, keeping it clean and efficient.

  • Dependency Modification
    The grpc/grpc software package has been moved from the project's main dependencies to its development dependencies in the composer.json file. This optimizes the packages that our software requires to run properly, ensuring that unnecessary packages are not installed in a production environment.

  • Documentation update
    A crucial instruction - how to manually add the grpc/grpc package - has been added to the grpc-application-runner.md. This provides clearer guidelines for developers and significantly helps in setting up the development environment.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29b1765) 100.00% compared to head (c9ed550) 100.00%.

❗ Current head c9ed550 differs from pull request most recent head 869a300. Consider uploading reports for the commit 869a300 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #76   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        27        27           
===========================================
  Files              3         3           
  Lines            125       125           
===========================================
  Hits             125       125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark
Copy link
Member

samdark commented Aug 23, 2023

Need a line for CHANGELOG.

CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit 8abdab5 into master Feb 22, 2024
11 of 14 checks passed
@vjik vjik deleted the issue_73 branch February 22, 2024 13:23
@vjik vjik mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants