Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows set named views in ContentDecorator::$viewFile #19624

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

WinterSilence
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

@bizley bizley added the pr:missing usecase It is not clear what is the use case for the pull request. label Oct 15, 2022
@yii-bot
Copy link

yii-bot commented Oct 15, 2022

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.

Could you supply us with a use case please? Please be as detailed as possible and show some code!

Thanks!

This is an automated comment, triggered by adding the label pr:missing usecase.

@WinterSilence
Copy link
Contributor Author

@bizley old implementation not support named views, look to updated example

@bizley bizley requested a review from a team October 20, 2022 16:01
@bizley bizley removed the pr:missing usecase It is not clear what is the use case for the pull request. label Oct 20, 2022
@rob006
Copy link
Contributor

rob006 commented Oct 20, 2022

Wouldn't be better to resolve view file in View::beginContent()? Passing view name as viewFile property looks a little bit off...

@WinterSilence
Copy link
Contributor Author

@rob006 View::beginContent() use $viewFile parameter and we can't change it

@rob006
Copy link
Contributor

rob006 commented Oct 20, 2022

Your PR already assumes that you pass view name as first argument of beginContent(). Resolving name in this method will reduce number of places where view name is used as viewFile.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.02%. Comparing base (b0aa6ab) to head (da8275f).

Files Patch % Lines
framework/widgets/ContentDecorator.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19624   +/-   ##
=======================================
  Coverage   48.02%   48.02%           
=======================================
  Files         445      445           
  Lines       43892    43892           
=======================================
  Hits        21080    21080           
  Misses      22812    22812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants