Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching a query to the db MsSQL with BLOB data type. #19903

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Fix caching a query to the db MsSQL with BLOB data type. #19903

merged 6 commits into from
Jul 24, 2023

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Jul 19, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #9899 - #9902

@what-the-diff
Copy link

what-the-diff bot commented Jul 19, 2023

PR Summary

  • **Bug fix 1: Corrected Cache Handling with Blob Data Type **
    A solution has been implemented to rectify an issue where queries to the database with BLOB (Large Binary) data was not being cached as expected.

  • Bug fix 2: Resolved Attribute Issue in Typecast Behavior
    This change rectifies an issue that would cause the system to show an "InvalidArgumentException" error message when the resetOldAttributes() function was used due to a problem with attribute naming.

  • Bug fix 3: Improved Handling of ReflectionUnionType Arguments
    Improved the functionality of the bindInjectedParams() function in the web controller, it will no longer produce an error when given an argument of type ReflectionUnionType.

  • Enhancement: Upgraded jQuery Version
    Updated the application to allow the installation of jQuery version 3.7, providing the benefits of the latest features and performance improvements from this version.

  • Code Alterations in DbCache.php and QueryBuilder.php
    Changes were made in these files to further optimize the queries run against the database, particularly those dealing with binary data. This improves the efficiency and accuracy of data retrieval and management.

  • Enhanced Testing and Validation in CommandTest.php
    Updated the test data structure and assertions for better alignment with the current application state and to ensure accurate results from tests.

  • Addition of Test Files
    Two new test files, QueryCacheTest.php and VarbinaryTest.php, have been added to better validate the query caching and varbinary functionalities within the system, further ensuring its robustness and reliability.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +32.62 🎉

Comparison is base (1a0e91e) 16.21% compared to head (7563a0b) 48.84%.

❗ Current head 7563a0b differs from pull request most recent head 92afba4. Consider uploading reports for the commit 92afba4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19903       +/-   ##
===========================================
+ Coverage   16.21%   48.84%   +32.62%     
===========================================
  Files         445      445               
  Lines       41121    42762     +1641     
===========================================
+ Hits         6668    20887    +14219     
+ Misses      34453    21875    -12578     
Impacted Files Coverage Δ
framework/caching/DbCache.php 64.49% <100.00%> (+64.49%) ⬆️
framework/db/mssql/QueryBuilder.php 52.81% <100.00%> (+52.81%) ⬆️

... and 293 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark added this to the 2.0.49 milestone Jul 24, 2023
@samdark samdark merged commit 79c83ba into yiisoft:master Jul 24, 2023
47 checks passed
@samdark
Copy link
Member

samdark commented Jul 24, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants