Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XCache and ZendDataCache support #19904

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Remove XCache and ZendDataCache support #19904

merged 3 commits into from
Jul 24, 2023

Conversation

mtangoo
Copy link
Contributor

@mtangoo mtangoo commented Jul 19, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues #19891

@mtangoo mtangoo added the severity:BC breaking Either breaks backwards compatibility or fixed previously made breakage label Jul 19, 2023
@mtangoo mtangoo added this to the 2.2.0 milestone Jul 19, 2023
@mtangoo mtangoo requested a review from a team July 19, 2023 08:52
@mtangoo mtangoo self-assigned this Jul 19, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jul 19, 2023

PR Summary

  • Excluded Wincache from Several Configuration Files
    The wincache component was removed from several configuration files. This includes changes in .appveyor.yml, .github/workflows/build.yml, and .gitlab-ci.yml. These ensures that wincache is no longer considered during specified workflows and test build processes.

  • Updated Cache Components Details on Documentation
    The document pages explaining caching data have been updated across various languages, including Spanish (docs/guide-es/caching-data.md), French (docs/guide-fr/caching-data.md), Japanese (docs/guide-ja/caching-data.md), Brazilian Portuguese (docs/guide-pt-BR/caching-data.md), Russian (docs/guide-ru/caching-data.md), Chinese (docs/guide-zh-CN/caching-data.md), and English (docs/guide/caching-data.md). These updates reflect the latest status of available cache components in the framework.

  • Removal of XCache and ZendDataCache
    XCache and ZendDataCache are removed from the framework/CHANGELOG.md indicating their change history and the upgrade guidelines in framework/UPGRADE.md. This removal signifies abandoning dependencies on these caching methods, implying they will not be supported in the future.

  • Cleanup of XCache and ZendDataCache Related Tests
    The test scripts XCacheTest.php and ZendDataCacheTest.php located in tests/framework/caching directory were removed. This change reflects the general cleanup effort following the deprecation of XCache and ZendDataCache. They are not part of the testing regime anymore since the components are no longer part of the framework.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -38.92 ⚠️

Comparison is base (6119515) 66.96% compared to head (80f1a9a) 28.04%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.2   #19904       +/-   ##
=============================================
- Coverage     66.96%   28.04%   -38.92%     
+ Complexity    11232    11215       -17     
=============================================
  Files           426      424        -2     
  Lines         35640    35611       -29     
=============================================
- Hits          23867     9988    -13879     
- Misses        11773    25623    +13850     
Impacted Files Coverage Δ
framework/classes.php 0.00% <ø> (ø)

... and 203 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtangoo
Copy link
Contributor Author

mtangoo commented Jul 19, 2023

Excluded Wincache from Several Configuration Files

Dunno why it pulled this one as wincache is untouched!

@samdark
Copy link
Member

samdark commented Jul 19, 2023

Dunno why it pulled this one as wincache is untouched!

GPT isn't precise :)

.phpunit.result.cache Outdated Show resolved Hide resolved
docs/guide/caching-data.md Outdated Show resolved Hide resolved
docs/guide-zh-CN/caching-data.md Outdated Show resolved Hide resolved
docs/guide-pt-BR/caching-data.md Outdated Show resolved Hide resolved
docs/guide-ja/caching-data.md Outdated Show resolved Hide resolved
docs/guide-fr/caching-data.md Outdated Show resolved Hide resolved
docs/guide-es/caching-data.md Outdated Show resolved Hide resolved
@mtangoo mtangoo requested a review from samdark July 19, 2023 16:45
@samdark samdark merged commit c9917f2 into yiisoft:2.2 Jul 24, 2023
29 of 30 checks passed
@samdark
Copy link
Member

samdark commented Jul 24, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:BC breaking Either breaks backwards compatibility or fixed previously made breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants