-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi line cell and longer $listPrefix in Table widget #19906
Fix multi line cell and longer $listPrefix in Table widget #19906
Conversation
PR Summary
|
…\yii\console\widgets\Table` widget)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #19906 +/- ##
=======================================
Coverage 48.84% 48.85%
=======================================
Files 445 445
Lines 42763 42781 +18
=======================================
+ Hits 20888 20901 +13
- Misses 21875 21880 +5
☔ View full report in Codecov by Sentry. |
…\yii\console\widgets\Table`
👍 |
Currently a multi line string breaks the table output, this PR fixes this.
From the unit test,
Current output:
Fixed output:
This PR also fixes a bug when $listPrefix doesn't have an exact length of 2 characters, for example
'-- '
.