Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for setCookieParams #19910

Closed
wants to merge 1 commit into from
Closed

Update documentation for setCookieParams #19910

wants to merge 1 commit into from

Conversation

clemens-it
Copy link
Contributor

The link for more information about "sameSite" leads to a 404 Not Found.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

The link for more information about "sameSite" lead to a 404 Not Found.
@what-the-diff
Copy link

what-the-diff bot commented Jul 25, 2023

PR Summary

  • Updating Documentation Link in Session.php
    The change made here has updated an obsolete link in Session.php to a new website URL. This new link gives users more detailed information about the attribute "sameSite".

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8c0ea9) 48.89% compared to head (29b7d7a) 48.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19910   +/-   ##
=======================================
  Coverage   48.89%   48.89%           
=======================================
  Files         445      445           
  Lines       42786    42786           
=======================================
  Hits        20919    20919           
  Misses      21867    21867           
Files Changed Coverage Δ
framework/web/Session.php 41.12% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clemens-it clemens-it closed this by deleting the head repository Jul 25, 2023
@rhertogh
Copy link
Contributor

@clemens-it Why was the PR closed?

@clemens-it
Copy link
Contributor Author

I deleted the repository from which originated the PR prematurely. My mistake.
Please advice, should I create a new PR from scratch?

@rhertogh
Copy link
Contributor

rhertogh commented Jul 29, 2023

Yes please, since I don't think this one can be reopened from a new repo (although we could try if it's created under the same name).

@clemens-it
Copy link
Contributor Author

clemens-it commented Jul 29, 2023

Ok, I just created a new PR -> #19921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants