Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary isset() checks and fix key exists checks #19914

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Remove unnecessary isset() checks and fix key exists checks #19914

merged 8 commits into from
Aug 18, 2023

Commits on Jul 26, 2023

  1. Removed optimization for PHP predating v7.4

    @rhertogh
    rhertogh committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4d60974 View commit details
    Browse the repository at this point in the history

  2. Fixed BaseArrayHelper::keyExists() and BaseArrayHelper::remove() … 

    …to deal with float keys (even when their value is `null`)
    @rhertogh
    rhertogh committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    000f164 View commit details
    Browse the repository at this point in the history

  3. Fixed typo in "Floats"

    @rhertogh
    rhertogh committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9efcd57 View commit details
    Browse the repository at this point in the history

  4. Skipp ArrayHelper float key tests for PHP >= v8.1

    @rhertogh
    rhertogh committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fe0260f View commit details
    Browse the repository at this point in the history

  5. updated changelog for yiisoft#19914 (Fixed ArrayHelper::keyExists()… 

    … and `::remove()` functions when the key is a float and the value is `null`)
    @rhertogh
    rhertogh committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a8a5678 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Removed optimization for PHP predating v7.4

    @rhertogh
    rhertogh committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e4e6865 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Marked todo comments in BaseArrayHelper as such

    @rhertogh
    rhertogh committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f1cb414 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Merge branch 'master' into remove_unnecessary_isset_checks

    @samdark
    samdark authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e847781 View commit details
    Browse the repository at this point in the history