Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary type #19932

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Remove unnecessary type #19932

merged 1 commit into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. Remove unnecessary type 

    Because Web and Console application extend Base application there is no need to specify it.

Actually, PHPStan narrows this to _just_ BaseApplication because it is the only consistent type of the three so you lose Web and Console Application type hints.

See, https://phpstan.org/r/d21fb99f-c436-480b-99c2-32df35ec07fa
    @markhuot
    markhuot authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b0b25f1 View commit details
    Browse the repository at this point in the history