Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex property to one of required option. #20212

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Add regex property to one of required option. #20212

merged 4 commits into from
Jul 4, 2024

Conversation

alxlnk
Copy link
Contributor

@alxlnk alxlnk commented Jun 24, 2024

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.98%. Comparing base (76150c5) to head (32688de).
Report is 2 commits behind head on master.

Files Patch % Lines
framework/widgets/MaskedInput.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20212   +/-   ##
=========================================
  Coverage     64.98%   64.98%           
- Complexity    11390    11391    +1     
=========================================
  Files           430      430           
  Lines         36919    36919           
=========================================
  Hits          23993    23993           
  Misses        12926    12926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added this to the 2.0.51 milestone Jun 30, 2024
@samdark
Copy link
Member

samdark commented Jun 30, 2024

Would you please add a line for changelog and a test?

@samdark samdark requested review from a team July 3, 2024 14:21
@alxlnk alxlnk requested a review from mtangoo July 4, 2024 10:31
@terabytesoftw
Copy link
Member

You could try the exception and the message, by using regex on the widget without the option alias, and wait.

$this->expectException('yii\base\InvalidConfigException');
$this->expectExceptionMessage('$this message exception')

@mtangoo mtangoo merged commit 5f5ef64 into yiisoft:master Jul 4, 2024
83 of 85 checks passed
@mtangoo
Copy link
Contributor

mtangoo commented Jul 4, 2024

@alxlnk thanks for your time and efforts

@alxlnk alxlnk mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants