Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed called class check in Widget::end() when widget configured using callable #20270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jrajamaki
Copy link

Fixes #20267

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20267

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.83%. Comparing base (3c75ff1) to head (02ef942).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20270      +/-   ##
============================================
- Coverage     64.95%   64.83%   -0.12%     
+ Complexity    11396    11394       -2     
============================================
  Files           430      430              
  Lines         36925    37130     +205     
============================================
+ Hits          23984    24073      +89     
- Misses        12941    13057     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark requested review from a team October 20, 2024 11:01
@samdark samdark added this to the 2.0.52 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget::end will crash if widget is configured by closure in di container
2 participants