Merge pull request #38 from exuanbo/fix-generated-type

fix: incorrect generated type of `WebrtcProvider` constructor
yjs · Jan 16, 2023 · 4685d36 · 4685d36
2 parents e3c1a74 + a60bad8
commit 4685d36
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -71,7 +71,7 @@
     "rollup-cli": "^1.0.9",
     "rollup-plugin-terser": "^5.3.1",
     "standard": "^14.3.4",
-    "typescript": "^3.9.10",
+    "typescript": "^4.4.4",
     "yjs": "^13.5.20"
   },
   "peerDependenies": {

diff --git a/src/y-webrtc.js b/src/y-webrtc.js
@@ -544,12 +544,12 @@ export class WebrtcProvider extends Observable {
    * @param {string} roomName
    * @param {Y.Doc} doc
    * @param {Object} [opts]
-   * @param {Array<string>?} [opts.signaling]
-   * @param {string?} [opts.password]
-   * @param {awarenessProtocol.Awareness?} [opts.awareness]
-   * @param {number?} [opts.maxConns]
-   * @param {boolean?} [opts.filterBcConns]
-   * @param {any?} [opts.peerOpts]
+   * @param {Array<string>} [opts.signaling]
+   * @param {string} [opts.password]
+   * @param {awarenessProtocol.Awareness} [opts.awareness]
+   * @param {number} [opts.maxConns]
+   * @param {boolean} [opts.filterBcConns]
+   * @param {any} [opts.peerOpts]
    */
   constructor (
     roomName,