Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Module::tracekind() to examine the kind of trace we have. #1525

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Dec 22, 2024

This is more idiomatic, and also allows us to catch one possible way that we might do things wrong.

This more idiomatic, and also allows us to catch one possible way that
we might do things wrong.
@ptersilie
Copy link
Contributor

Is there a file missing here or have you introduced TraceKind in another PR that I've missed?

@ltratt
Copy link
Contributor Author

ltratt commented Dec 22, 2024

It was introduced in #1523.

@ptersilie ptersilie added this pull request to the merge queue Dec 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2024
@ltratt
Copy link
Contributor Author

ltratt commented Dec 22, 2024

I think this is another of our favourite nondeterministic errors. Retry?

@vext01 vext01 added this pull request to the merge queue Dec 23, 2024
Merged via the queue into ykjit:master with commit 11f6391 Dec 23, 2024
2 checks passed
@ltratt ltratt deleted the use_tracekind branch December 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants