You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements a number of new trace optimisations (most of which I realised are necessary by tracing some Lua programs with yklua), and tidies up some of the trace optimiser along the way. Each commit should be self-contained.
I noticed (because I made a mistake!) that we weren't testing the
canonicalisation cases properly. This commit looks like it changes much
more than it really does: basically we add a comment to the main
optimiser code which causes lots of indenting and churn without any
meaningful changes. The meat of the commit is the test cases at the end.
Oof, it seems we are probably hitting a codegen problem with xor and i1. I think this reflects a deep flaw in our IR where we use byte size instead of bit size. I can fix this, but it won't be quick. My suggestion is that I remove the Xor commit (which will cause some conflicts with the next commit), force push, and then I can fix the deeper problem.
OK, so this is actually because we (well... the perpendicular pronoun would be more accurate) didn't consider signed/zero extension in constants in the codegen. I have a partial fix but I need to audit the whole module for other instances. That's a tomorrow job.
#1553 fixes a problem that happens to manifest in this PR (but isn't caused by this PR) with havlak. When #1553 merges, we should be able to retry this PR, but Bounce may still cause us problems.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ltratt
force-pushed
the
more_trace_opts
branch
from
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This PR implements a number of new trace optimisations (most of which I realised are necessary by tracing some Lua programs with yklua), and tidies up some of the trace optimiser along the way. Each commit should be self-contained.