Break the optimiser into separate functions. #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimiser has now exceeded even my (high!) tolerance for long
functions. Previously it was structured as:
```rust
match inst {
Inst::A => {
...
}
Inst::B => {
...
}
}
```
where the `...`s could be arbitrarily long.
This commit -- which has no functional change, despite its size! --
changes the structure to:
```rust
match inst {
Inst::A => self.opt_a(...),
Inst::B => self.opt_b(...),
}
```
So now each instruction has its "own" function. `opt_binop` is still
fearsomely large, but this commit moves us in a more sustainable
direction.
|
Bravo! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Bounce failed. Unlikely to be related to this PR! Can we retry please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimiser has now exceeded even my (high!) tolerance for long functions. Previously it was structured as:
where the
...s could be arbitrarily long.This commit -- which has no functional change, despite its size! -- changes the structure to:
So now each instruction has its "own" function.
opt_binopis still fearsomely large, but this commit moves us in a more sustainable direction.