Merge pull request #162 from ynput/bugfix/do_not_log_noop_patches

Prevent creating *changed events when a patch is noop
ynput · May 2, 2024 · 3753ba7 · 3753ba7
2 parents 1ba21a5 + 2cd9617
commit 3753ba7
Showing 1 changed file with 21 additions and 15 deletions.
diff --git a/ayon_server/events/patch.py b/ayon_server/events/patch.py
@@ -172,20 +172,26 @@ def build_pl_entity_change_events(
     for column_name, topic_name in ADDITIONAL_COLUMNS.items():
         if not hasattr(original_entity, column_name):
             continue
-        if column_name in patch_data:
-            description = f"Changed {entity_type} {original_entity.name} {column_name}"
-            result.append(
-                {
-                    "topic": f"entity.{entity_type}.{topic_name}",
-                    "description": description,
-                    **common_data,
-                }
-            )
-            if ayonconfig.audit_trail:
-                payload = {
-                    "oldValue": getattr(original_entity, column_name),
-                    "newValue": patch_data[column_name],
-                }
-                result[-1]["payload"] = payload
+
+        if column_name not in patch_data:
+            continue
+
+        if getattr(original_entity, column_name) == patch_data.get(column_name):
+            continue
+
+        description = f"Changed {entity_type} {original_entity.name} {column_name}"
+        result.append(
+            {
+                "topic": f"entity.{entity_type}.{topic_name}",
+                "description": description,
+                **common_data,
+            }
+        )
+        if ayonconfig.audit_trail:
+            payload = {
+                "oldValue": getattr(original_entity, column_name),
+                "newValue": patch_data[column_name],
+            }
+            result[-1]["payload"] = payload
 
     return result