Expose function to locate workdir #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in Deadline addon (safely) to render to `renders` folder in workdir instead of next to published file.
kalisp
added
the
type: enhancement
BigRoy
reviewed
Dec 20, 2024
Comment on lines
+642
to
+643
| def get_workdir(): | ||
| return ProcessContext.workfile_path |
There was a problem hiding this comment.
Isnt' the workfile path always kept "live" in AYON regardless, by using AYON_WORKDIR since it updates on task change?
So couldn't we technically just rely on AYON_WORKDIR?
BigRoy
reviewed
Dec 20, 2024
Comment on lines
+404
to
+405
| elif tool_name == "publisher": | ||
| kwargs["tab"] = "publish" |
|
Closing as function is not necessary, env var |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This is used in Deadline addon (safely) to render to
rendersfolder in workdir instead of next to published file.Additional review information
Required for ynput/ayon-deadline#91