-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre launch hook for installing AYON extension #6
Conversation
+ improved logging
Hit permissions error due to Extensions being installed to system path, seems that ExManCmd may also be replaced, will look into alternative shortly. |
I added check for extension version, if different found, deployed extension folder gets purged and redeployed. If you could @Sponge96 give it a go, please. |
haha I was literally working on this and about to push as well, will see if my version does anything different |
client/ayon_premiere/hooks/pre_launch_install_ayon_extension.py
Outdated
Show resolved
Hide resolved
client/ayon_premiere/hooks/pre_launch_install_ayon_extension.py
Outdated
Show resolved
Hide resolved
@kalisp ours are very similar, mine branches off at the check on if the folder exist and uses the xml parser, I've thrown the code here and I guess we can see if you want to pinch anything or if we keep with your impl @BigRoy tagging for opinion as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with admin and standard user accounts, works in both cases.
Merged, thanks for contribution @Sponge96 :). |
Changelog Description
A simple prelaunch hook that automates the install of the AYON Premiere extension.
Additional review information
Right now for both Premiere and AfterEffect the users are expected to install the AYON extension via ExManCmd or Anastasiy's Extension Manager (see: https://github.com/ynput/ayon-aftereffects/blob/05dee927235bcdb654ce27fbed3d4f07fbd8f1dc/client/ayon_aftereffects/api/README.md). In my opinion it's better for AYON to handle this process instead of the user, it's a bit too technical for most users.
I'm creating this PR as a starting point on the discussion of how better to integrate the Adobe products into AYON as this method (or something similar) could easily be reused in AfterEffects.
Edit: The initial implementation attempted to use the ExManCMD cli tool to automate but we quickly hit permissions error due to the extraction of the .zxp being to a system path. The new approach simply creates a folder in the users appdata and unzip's the contents of the .zxp directly to that folder.
IMPORTANT: If you have already installed the AYON Premiere extension to users you will need to remove this via the tool you used (either ExManCmd or Anastasiy's Extension Manager) since they are located in system paths we are unable to remove these due to permissions. You will not experience any error by having the extension in both paths BUT its a gamble on which one it's actually loading.
Testing notes:
1. Upload new Premiere addon to server2. Configure bundle to include new addon version.
3. Enable the new hook via settings
4. Install ExManCmd
5. Populate "Path to ExManCmd executable"
6. Launch Premiere
7. Check that the extension has installed (Window->Extensions->AYON)