fix: drop AttachGuard only after all GlobalRefs in JReaderInputStream are dropped #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Ah, I see. This seems to be incompatible with the Python bindings, because pyobjects have to be |
mjpowersjr
added a commit
to ProSync/extractous
that referenced
this pull request
Nov 21, 2025
This commit addresses multiple critical stability issues and enhances file format support through dependency upgrades and metadata improvements. Key Changes: - Upgrade Apache Tika from 2.9.2 to 2.9.3 (last stable 2.x release) - Fix JNI memory management in JReaderInputStream Drop implementation - Add 33 missing OOXML class definitions to GraalVM reflection metadata - XLSX support: CTWorkbook, CTWorksheet, CTCell, CTRow classes - PPTX SmartArt: CTDiagram, CTDataModel, CTLayoutNode classes - Visio support: PageContentsDocument, VisioDocument classes - Additional XMLBeans and Word processing classes - Fix documentation inconsistencies in config defaults (4 fixes) - Add workspace sections to Cargo.toml files for independent builds Issues Addressed: - yobix-ai#64: JNI memory management and GlobalRef cleanup order - yobix-ai#60: RuntimeException with XLSX files - yobix-ai#58: JniError with PPTX files containing SmartArt - yobix-ai#40: Visio graphics in DOC files causing failures - yobix-ai#44: Inconsistent config default documentation All changes focus on stability and file format compatibility without adding new features. Tests pass successfully with core extraction functionality verified. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the library!
When using the Streams for text extraction,
GlobalRefs are dropped after the thread is already detached from the VM. This leads to a warning from jni crate:I fixed this by including the
AttachGuardin theJReaderInputStreamstruct, so that the thread is detached only after all GlobalRefs in it are dropped.(also, the tagged v0.3.0 commit is not part of any branch in this repository and main is outdated)