Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base docs #127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

base docs #127

wants to merge 3 commits into from

Conversation

AleksandrRazhev
Copy link
Contributor

@AleksandrRazhev AleksandrRazhev commented Aug 16, 2022 •
edited
Loading

img

droganov
droganov requested changes Sep 6, 2022
View reviewed changes
src/react/Base/Base.stories.mdx Outdated

---

## Base Disabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yobta Disabled

src/react/Base/Base.stories.mdx Outdated
## Base Disabled

<Canvas>
<Story name="Base Disabled">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yobta Disabled

src/react/Base/Base.stories.mdx Outdated
</Story>
</Canvas>

## Base No Tap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yobta no Tap

src/react/Base/Base.stories.mdx Outdated
## Base No Tap

<Canvas>
<Story name="Base No Tap">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yobta no Tap

droganov
droganov requested changes Sep 6, 2022
View reviewed changes
src/react/Base/Base.stories.mdx
<Canvas>
<Story name="Yobta No Tap">
<div className="">
<button className="p-2 bg-paper-primary ui-text-ink rounded block yobta-no-tap mb-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Странный выбор классов, например белый текст на жёлтом не читается, хотя на уровне библиотеки такая проблема решена и есть класс который позволяет не иметь таких проблем

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droganov droganov droganov requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleksandrRazhev @droganov