Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed return type of WorkflowControllerTrait::getWorkflow for WorkflowInterface #37

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

KevinEcotree
Copy link
Contributor

With Symfony 6.4, I get this error:
Yokai\SonataWorkflow\Controller\WorkflowController::getWorkflow(): Return value must be of type Symfony\Component\Workflow\Workflow, Symfony\Component\Workflow\Debug\TraceableWorkflow returned

Changing the return value to WorkflowInterface corrects the problem.

@KevinEcotree KevinEcotree deleted the patch-1 branch January 11, 2024 16:06
@KevinEcotree KevinEcotree restored the patch-1 branch January 11, 2024 16:06
@KevinEcotree KevinEcotree reopened this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6b9fb4) 89.55% compared to head (1135a49) 89.55%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #37   +/-   ##
=========================================
  Coverage     89.55%   89.55%           
  Complexity       45       45           
=========================================
  Files             2        2           
  Lines           201      201           
=========================================
  Hits            180      180           
  Misses           21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yann-eugone yann-eugone changed the title change the return value of the getWorkflow method of WorkflowControllerTrait Changed return type of WorkflowControllerTrait::getWorkflow for WorkflowInterface Jan 12, 2024
@yann-eugone
Copy link
Contributor

Hi 🙂

I thought it was a duplicate of #36, but it seems that we just forgot another place where return type should be changed.
So, thanks for this PR

@yann-eugone yann-eugone merged commit 71a1566 into yokai-php:main Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants