fixed link issues and added non ja example for walkthrough #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmaa
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Make these webp and put them in ss/ (screenshots)
There was a problem hiding this comment.
Is the only difference the screenshots?
There was a problem hiding this comment.
yes and I removed the kanji section + mentions of japanese, I wasn't sure if there was anything else that was different between using japanese and not using japanese.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #39
There was an issue with the links for edge, there is also an issue with I think how github auto formats files? the css classes dont show up locally but they do on github? Added a walkthrough example but just replaced the japanese parts with english instead.