Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord link to header #68

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

khaitruong922
Copy link
Contributor

Closes #59

@jamesmaa
Copy link
Contributor

Do you know if it's possible to extend the theme so we limit the amount of copy+paste we do? https://squidfunk.github.io/mkdocs-material/customization/#extending-the-theme

@khaitruong922
Copy link
Contributor Author

Due to how the header HTML is structured, to insert the Discord icon, there is no other partials to override other than header.html.
https://github.com/squidfunk/mkdocs-material/blob/master/src/templates/partials/header.html

Override blocks only allow us to insert at the start or end of the header, therefore it is not possible to insert the Discord icon which is in the middle of header.
https://squidfunk.github.io/mkdocs-material/customization/#overriding-blocks

@jamesmaa
Copy link
Contributor

Can you fix the broken link checker by adding it to lycheeignore?

@jamesmaa jamesmaa merged commit ba29026 into yomidevs:master Oct 24, 2024
1 check passed
@khaitruong922 khaitruong922 deleted the add-discord-icon branch October 24, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add discord link to header
2 participants