update typing

yomidevs · Oct 17, 2024 · 1af5cde · 1af5cde
1 parent bdbc635
commit 1af5cde
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/ext/js/background/backend.js b/ext/js/background/backend.js
@@ -1463,7 +1463,9 @@ export class Backend {
         /** @type {import('translator').FindTermsMode} */
         const mode = 'simple';
         const options = this._getProfileOptions(optionsContext, false);
-        const details = {matchType: /** @type {import('translation').FindTermsMatchType} */ ('exact'), deinflect: true, reading: null};
+
+        /** @type {import('api').FindTermsDetails} */
+        const details = {matchType: 'exact', deinflect: true};
         const findTermsOptions = this._getTranslatorFindTermsOptions(mode, details, options);
         /** @type {import('api').ParseTextLine[]} */
         const results = [];

diff --git a/ext/js/display/display.js b/ext/js/display/display.js
@@ -1265,7 +1265,7 @@ export class Display extends EventDispatcher {
     /**
      * @param {boolean} isKanji
      * @param {string} source
-     * @param {string | null} reading
+     * @param {string | undefined} reading
      * @param {boolean} wildcardsEnabled
      * @param {import('settings').OptionsContext} optionsContext
      * @returns {Promise<import('dictionary').DictionaryEntry[]>}
@@ -1290,7 +1290,7 @@ export class Display extends EventDispatcher {
 
     /**
      * @param {string} source
-     * @param {string | null} reading
+     * @param {string | undefined} reading
      * @param {boolean} wildcardsEnabled
      * @returns {{findDetails: import('api').FindTermsDetails, source: string}}
      */
@@ -1321,7 +1321,7 @@ export class Display extends EventDispatcher {
     async _setContentTermsOrKanji(type, urlSearchParams, token) {
         const lookup = (urlSearchParams.get('lookup') !== 'false');
         const wildcardsEnabled = (urlSearchParams.get('wildcards') !== 'off');
-        const reading = urlSearchParams.get('reading');
+        const reading = urlSearchParams.get('reading') ?? undefined;
         const hasEnabledDictionaries = this._options ? this._options.dictionaries.some(({enabled}) => enabled) : false;
 
         // Set query

diff --git a/types/ext/api.d.ts b/types/ext/api.d.ts
@@ -48,7 +48,7 @@ import type {
 export type FindTermsDetails = {
     matchType?: Translation.FindTermsMatchType;
     deinflect?: boolean;
-    reading: string | null;
+    reading?: string;
 };
 
 export type ParseTextResultItem = {

diff --git a/types/ext/translation.d.ts b/types/ext/translation.d.ts
@@ -71,7 +71,7 @@ export type FindTermsOptions = {
     /**
      * Exact reading of the term.
      */
-    reading: string | null;
+    reading: string | undefined;
     /**
      * The name of the primary dictionary to search.
      */