Merge branch 'master' into language-select

yomidevs · Feb 1, 2024 · 61e0ff6 · 61e0ff6
2 parents 77e7944 + 711520e
commit 61e0ff6
Show file tree

Hide file tree

Showing 10 changed files with 45 additions and 42 deletions.
diff --git a/.github/workflows/auto-approve-run.yml b/.github/workflows/auto-approve-run.yml
@@ -21,7 +21,7 @@ jobs:
             run_id: ${{ github.event.workflow_run.id }}
       - name: Read the pr_num file
         id: pr_num_reader
-        uses: juliangruber/read-file-action@02bbba9876a8f870efd4ad64e3b9088d3fb94d4b # v1.1.6
+        uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
         with:
             path: ./pr_num/pr_num.txt
       - uses: hmarr/auto-approve-action@44888193675f29a83e04faf4002fa8c0b537b1e4 # v3.2.1

diff --git a/.github/workflows/broken-links.yml b/.github/workflows/broken-links.yml
@@ -21,7 +21,7 @@ jobs:
         run: npm ci
       - name: Build Legal
         run: npm run license-report
-      - uses: lycheeverse/lychee-action@ec3ed119d4f44ad2673a7232460dc7dff59d2421
+      - uses: lycheeverse/lychee-action@c053181aa0c3d17606addfe97a9075a32723548a
         with:
           fail: true
           jobSummary: false

diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -34,7 +34,7 @@ jobs:
 
       - name: Cache playwright browsers
         id: cache-playwright
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: |
             ~/.cache/ms-playwright

diff --git a/.github/workflows/publish-chrome-development.yml b/.github/workflows/publish-chrome-development.yml
@@ -38,7 +38,7 @@ jobs:
               return attempt < max ? attempt + 1 : '';
             }
 
-      - uses: robinraju/release-downloader@efa4cd07bd0195e6cc65e9e30c251b49ce4d3e51 # pin@v1.8
+      - uses: robinraju/release-downloader@368754b9c6f47c345fcfbf42bcb577c2f0f5f395 # pin@v1.9
         with:
           tag: ${{ github.ref_name }}
           fileName: "*"

diff --git a/.github/workflows/publish-chrome.yml b/.github/workflows/publish-chrome.yml
@@ -38,7 +38,7 @@ jobs:
               return attempt < max ? attempt + 1 : '';
             }
 
-      - uses: robinraju/release-downloader@efa4cd07bd0195e6cc65e9e30c251b49ce4d3e51 # pin@v1.8
+      - uses: robinraju/release-downloader@368754b9c6f47c345fcfbf42bcb577c2f0f5f395 # pin@v1.9
         with:
           tag: ${{ github.ref_name }}
           fileName: "*"

diff --git a/.github/workflows/publish-firefox-development.yml b/.github/workflows/publish-firefox-development.yml
@@ -20,7 +20,7 @@ jobs:
     outputs:
       hashes: ${{ steps.hash.outputs.hashes }}
     steps:
-      - uses: robinraju/release-downloader@efa4cd07bd0195e6cc65e9e30c251b49ce4d3e51 # pin@v1.8
+      - uses: robinraju/release-downloader@368754b9c6f47c345fcfbf42bcb577c2f0f5f395 # pin@v1.9
         with:
           tag: ${{ github.ref_name }}
           fileName: "*"

diff --git a/.github/workflows/publish-firefox.yml b/.github/workflows/publish-firefox.yml
@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     environment: cd
     steps:
-      - uses: robinraju/release-downloader@efa4cd07bd0195e6cc65e9e30c251b49ce4d3e51 # pin@v1.8
+      - uses: robinraju/release-downloader@368754b9c6f47c345fcfbf42bcb577c2f0f5f395 # pin@v1.9
         with:
           tag: ${{ github.ref_name }}
           fileName: "*"

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -68,14 +68,14 @@
         "eslint": "^8.56.0",
         "eslint-plugin-eslint-comments": "^3.2.0",
         "eslint-plugin-header": "^3.1.1",
-        "eslint-plugin-jsdoc": "^47.0.1",
+        "eslint-plugin-jsdoc": "^48.0.4",
         "eslint-plugin-jsonc": "^2.11.2",
         "eslint-plugin-no-unsanitized": "^4.0.2",
         "eslint-plugin-unused-imports": "^3.0.0",
         "eslint-plugin-vitest": "^0.3.20",
         "fake-indexeddb": "^5.0.2",
         "html-validate": "^8.8.0",
-        "jsdom": "^23.0.1",
+        "jsdom": "^24.0.0",
         "jszip": "^3.10.1",
         "license-report": "^6.5.0",
         "stylelint": "^16.1.0",

diff --git a/test/dictionary-data.write.js b/test/dictionary-data.write.js
@@ -35,7 +35,10 @@ const dirname = path.dirname(fileURLToPath(import.meta.url));
 const dictionaryName = 'Test Dictionary 2';
 const test = await createTranslatorTest(void 0, path.join(dirname, 'data/dictionaries/valid-dictionary1'), dictionaryName);
 
-test('Write dictionary data expected data', async ({translator, expect}) => {
+test('Write dictionary data expected data', async ({window, translator, expect}) => {
+    // The window property needs to be referenced for it to be initialized.
+    // It is needed for DOM access for structured content.
+    void window;
     const testInputsFilePath = path.join(dirname, 'data/translator-test-inputs.json');
     /** @type {import('test/translator').TranslatorTestInputs} */
     const {optionsPresets, tests} = parseJson(readFileSync(testInputsFilePath, {encoding: 'utf8'}));