Disable no update button (#1354)

* disable no updates button * check if has update
yomidevs · Aug 25, 2024 · fb7f116 · fb7f116
1 parent 2f1b77c
commit fb7f116
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/ext/js/pages/settings/dictionary-controller.js b/ext/js/pages/settings/dictionary-controller.js
@@ -958,17 +958,22 @@ export class DictionaryController {
     /** */
     async _checkForUpdates() {
         if (this._dictionaries === null || this._checkingIntegrity || this._checkingUpdates || this._isDeleting) { return; }
+        let hasUpdates;
         try {
             this._checkingUpdates = true;
             this._setButtonsEnabled(false);
 
             const updateChecks = this._dictionaryEntries.map((entry) => entry.checkForUpdate());
             const updateCount = (await Promise.all(updateChecks)).reduce((sum, value) => (sum + (value ? 1 : 0)), 0);
             if (this._checkUpdatesButton !== null) {
-                this._checkUpdatesButton.textContent = updateCount ? `${updateCount} update${updateCount > 1 ? 's' : ''}` : 'No updates';
+                hasUpdates = !!updateCount;
+                this._checkUpdatesButton.textContent = hasUpdates ? `${updateCount} update${updateCount > 1 ? 's' : ''}` : 'No updates';
             }
         } finally {
             this._setButtonsEnabled(true);
+            if (this._checkUpdatesButton !== null && !hasUpdates) {
+                this._checkUpdatesButton.disabled = true;
+            }
             this._checkingUpdates = false;
         }
     }