Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Japanese transforms #1413

Merged
merged 33 commits into from
Sep 18, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Sep 12, 2024

update descriptions, add i18n for all forms, fix typo, etc.

rename all past keywords to -ta, reason: #1007

rename all romaji terms to Japanese

Fixes #1416

@khaitruong922 khaitruong922 requested a review from a team as a code owner September 12, 2024 15:06
@khaitruong922 khaitruong922 changed the title Refactor Japanese description Refactor Japanese transform descriptions Sep 12, 2024
@khaitruong922 khaitruong922 changed the title Refactor Japanese transform descriptions Refactor Japanese transforms Sep 12, 2024
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Sep 12, 2024
ext/js/language/ja/japanese-transforms.js Outdated Show resolved Hide resolved
ext/js/language/ja/japanese-transforms.js Outdated Show resolved Hide resolved
ext/js/language/ja/japanese-transforms.js Outdated Show resolved Hide resolved
ext/js/language/ja/japanese-transforms.js Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #1413 will not alter performance

Comparing khaitruong922:update-ja-description (dd87214) with master (547a628)

Summary

✅ 4 untouched benchmarks

🆕 1 new benchmarks
⁉️ 1 (👁 1) dropped benchmarks

Benchmarks breakdown

Benchmark master khaitruong922:update-ja-description Change
🆕 japanese transformations-full (n=212) N/A 50.5 ms N/A
👁 japanese transformations-full (n=214) 51.5 ms N/A N/A

@jamesmaa jamesmaa added this pull request to the merge queue Sep 18, 2024
Merged via the queue into yomidevs:master with commit 5212502 Sep 18, 2024
9 checks passed
@khaitruong922 khaitruong922 deleted the update-ja-description branch September 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja]: imperative negative is redundant
4 participants