Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector in example styles.css #1415

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

stephenmk
Copy link

The selector without the ul name will work in Firefox, but it does not work in Chromium (and probably Edge, although I didn't test).

The selector without the `ul` name will work in Firefox, but it does not work in Chromium

Signed-off-by: Stephen Kraus <8003332+stephenmk@users.noreply.github.com>
@stephenmk stephenmk requested a review from a team as a code owner September 13, 2024 05:14
@stephenmk
Copy link
Author

stephenmk commented Sep 13, 2024

Likely that the "styles" entry in test/data/database-test-cases.json may need to be updated as well, although it seems all the automated tests passed.

Edit: had to scroll down to see that the CI / Unit Tests (pull_request) step failed. I'll look into it tomorrow.

Signed-off-by: Stephen Kraus <8003332+stephenmk@users.noreply.github.com>
@stephenmk stephenmk marked this pull request as draft September 13, 2024 06:48
@stephenmk stephenmk marked this pull request as ready for review September 13, 2024 21:48
@stephenmk
Copy link
Author

Okay, I had to also add the ul name to the selectors in anki-note-builder-test-results.json and translator-test-results-note-data1.json to get the unit tests to pass.

Just to reiterate, I think this fix is important because this error could mislead people into thinking the element names are not necessary in these CSS selectors. If you load the current version of the valid test dictionary into Yomitan on firefox, you'll see that the text in the entry for ばね is yellow as expected. It does not work on Chromium, at least for me.

@jamesmaa jamesmaa added this pull request to the merge queue Sep 14, 2024
Merged via the queue into yomidevs:master with commit 28d0a14 Sep 14, 2024
9 checks passed
@Casheeew Casheeew added area/documentation The issue or PR is about documentation kind/meta The issue or PR is meta labels Sep 24, 2024
@stephenmk stephenmk deleted the ex-css-fix branch October 18, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation The issue or PR is about documentation kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants