Add None Popup Shadow Option
#1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvNC
force-pushed
the
add-none-outer-theme
branch
from
a513050
to
35fbfbe
Compare
MarvNC
force-pushed
the
add-none-outer-theme
branch
from
35fbfbe
to
b9aee43
Compare
MarvNC
commented
Sep 17, 2024
| @@ -371,9 +371,9 @@ export type PopupVerticalTextPosition = 'default' | 'before' | 'after' | 'left' | |||
|
|
|||
| export type GlossaryLayoutMode = 'default' | 'compact'; | |||
|
|
|||
| export type PopupTheme = 'light' | 'dark' | 'browser'; | |||
There was a problem hiding this comment.
Was this just missed? It seemed to be missing so I just added it for completeness.
Casheeew
approved these changes
Sep 17, 2024
Casheeew
added
kind/enhancement
|
Semi-related: Tbh I think having the popup shadow be customizable is kind of overkill. I think if we wanted to simplify the UX of the settings page I would bundle this option with the body dropdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1422