syntax error message made more verbose #1462
Conversation
made the syntax error when validating a dictionary also provide the name of the term bank that contains the error
|
Can you add screenshots of before and after? |
|
Before |
| catch (error) { | ||
| if (error instanceof Error) { | ||
| let newError = new Error(error.message + `. Dictionary has invalid data in '${file.filename}'`); | ||
| console.error(newError); |
There was a problem hiding this comment.
You should use log.error instead. log is a wrapper around console.
There was a problem hiding this comment.
Thank you. Can you elaborate on what makes log.error more appropriate?
There was a problem hiding this comment.
You can check out https://github.com/themoeway/yomitan/blob/master/ext/js/core/log.js#L74. It basically formats the log with info for the extension.
| catch (error) { | ||
| if (error instanceof Error) { | ||
| let newError = new Error(error.message + `. Dictionary has invalid data in '${file.filename}'`); | ||
| console.error(newError); |
There was a problem hiding this comment.
In addition, I don't think it's useful logging here and still letting the error propagate. If I decided to log the errors upstream, it would cause the error to be logged twice. You can remove the console.error entirely.
There was a problem hiding this comment.
Ok. I'll do away with it entirely.
|
Made changes |
Kuuuube
added
kind/enhancement
when validating a dictionary as it is being imported, if a syntax error is encountered, a message would describe the syntax error that has occurred. To provide clarity, the syntax error message will now also describe the file in which this error occurred.