Add term tags to {tags} Anki field

[khaitruong922]

Fixes #1454

[MarvNC]

Maybe it should be a separate handlebar?

[khaitruong922]

Maybe it should be a separate handlebar?

We can expose the definition.termTags as a separate handlebar. If people only want to have either type of tags then it can be useful but I think it's kinda overkill and may cause confusion between {term-tags} and {definition-tags}.

@Kuuuube thoughts?

[Kuuuube]

Best to avoid renaming existing handlebars if it can be avoided. Not sure what the use case for the current tags is to know if this matters.

[khaitruong922]

Current {tags} field only returns tags from term definitions (for example n, v5, abbr) but not the tags of the term itself (mostly from JMDict) like news20k, ichi, rare tag, high priority term tag, etc.

Currently there is no handlebar to retrieve the term tags, so I add those into the {tags} anki field. I think use cases which requires a separate handlebar are quite limited.

[codspeed-hq]

CodSpeed Performance Report

Merging #1464 will not alter performance

_{Comparing khaitruong922:tags-headword (ce314de) with master (73793a4)}

Summary

✅ 3 untouched benchmarks

[jamesmaa]

@Kuuuube could you approve if you feel like PR is mergeable?

I feel like if we think {tags} should include both term and definition tags, then let's not worry about existing user expectations and Hyrum's Law we really don't have an API contract with our users nor a way to roll out these changes without violating user behaviors sometimes. I don't think that should stop up from doing the right thing if we believe it's the right thing

[stephenmk]

Term tags serve a different purpose than definition tags. The definition tags are displayed once at the top of a yomitan term, and there could be one or many different sets of term tags displayed underneath. I'm not sure how exactly this new setup works (nobody has posted anki screenshots), but if the definition tags are repeated in each of these term tag sets, I imagine it would look very cluttered and I expect many users would be unhappy.

(Edit: I got "term" and "definition" reversed)

(Edit 2: I looked a bit more and I was actually thinking of the glossary handlebar, so never mind)

[Kuuuube]

I'm fine with it as long as it works as it is said (tests look fine). I haven't had the chance to test this myself.

As for users depending on this, this is for sure one of the least used handlebars we have. I've never seen anyone use it.