-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add term tags to {tags}
Anki field
#1464
Conversation
Maybe it should be a separate handlebar? |
We can expose the @Kuuuube thoughts? |
Best to avoid renaming existing handlebars if it can be avoided. Not sure what the use case for the current tags is to know if this matters. |
Current {tags} field only returns tags from term definitions (for example Currently there is no handlebar to retrieve the term tags, so I add those into the {tags} anki field. I think use cases which requires a separate handlebar are quite limited. |
CodSpeed Performance ReportMerging #1464 will not alter performanceComparing Summary
|
@Kuuuube could you approve if you feel like PR is mergeable? I feel like if we think |
(Edit 2: I looked a bit more and I was actually thinking of the glossary handlebar, so never mind) |
I'm fine with it as long as it works as it is said (tests look fine). I haven't had the chance to test this myself. As for users depending on this, this is for sure one of the least used handlebars we have. I've never seen anyone use it. |
This reverts commit 26e843d.
Fixes #1454