Add screenshot of welcome page in visual test

[MarvNC]

Resolves #386

Playwright:

[codspeed-hq]

CodSpeed Performance Report

Merging #1477 will degrade performances by 14.27%

_{Comparing MarvNC:add-welcome-page-test (a8e12aa) with master (7acf87e)}

Summary

❌ 1 regressions
✅ 4 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	master	MarvNC:add-welcome-page-test	Change
❌	japanese transformations (n=78)	20 ms	23.4 ms	-14.27%

[github-actions]

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

[MarvNC]

oh

any idea why this is happening when the screenshot itself succeeded?

[djahandarie]

@MarvNC Hmm, no idea actually, since it's not a soft except, I would expect it to terminate and not take the screenshot. Are you sure the screenshot file isn't present from the last time you ran it?

Anyways, the fix would be to choose an element that isn't hidden, I guess. Or switch to toHaveCount(1)

[MarvNC]

Ah I meant in the initial playwright report the first time yeah, it failed to take the screenshot after the change using that selector. Anyway changed it to use page.getByText('Welcome to Yomitan!')) which probably makes more sense anyway and it worked!