Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page displays queried sentence even when parser is off. #1513

Closed
wants to merge 0 commits into from

Conversation

austinyu12
Copy link

@austinyu12 austinyu12 commented Oct 21, 2024

Addresses #1370. When a parser is on, it will still parse words putting spaces in-between, which is not good for the user, but the result we expect. When all parsers are off, it will now only update text and not parse.

Before, Parser On:
Screenshot 2024-10-20 at 11 22 38 PM

Before, Parser Off:
Screenshot 2024-10-20 at 11 24 49 PM

New Code, Parser On:
Screenshot 2024-10-20 at 11 24 12 PM

New Code, Parser Off:
Screenshot 2024-10-20 at 11 25 13 PM

@austinyu12 austinyu12 requested a review from a team as a code owner October 21, 2024 06:30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have been accidentally pulled in. Please revert that.

@Kuuuube
Copy link
Member

Kuuuube commented Oct 21, 2024

Also dont use master branch for prs. It works if you only make a single pr at a time but as soon as you want to open a second one it's a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants