WIP: Fix example text popup not updating correctly when scan resolution is set to word
#1527
+25
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #1526
Currently able to repro in a test case. So far what I can observe:
The
textSource
range starts on theText
node of "read" with offset 0. We then try to set the startOffset of thetextSource
back to find the beginning of the word (trying to find the word boundary). Since the starting point is theText
node atoffset
0, it basically exits thespan
class and starts to read the text node between theinput
and thespan
elements, consisting of aText
node with values\n
. Then the DOMTextScanner hits the space that it considers a word boundary and then stops there, returning a range that starts at theText
node with "\n " when I think it should basically stop where it started.Still unsure why this bug is not triggered with normal text scanning at the beginning of a word