-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deinflection cycle testing #477
Deinflection cycle testing #477
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
What I meant in #471 (comment) was; {"kanaIn": "てもうた", "kanaOut": "てしまった", "rulesIn": [], "rulesOut": []},
{"kanaIn": "しまった", "kanaOut": "もうた", "rulesIn": [], "rulesOut": []} then |
Adding that rule group and setting
|
My misunderstanding then. 😄 |
In general, the danger comes from situations where |
d1bbadc
to
a920d2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did you still want to Rebase and test after https://github.com/themoeway/yomitan/pull/547.
or are we good to go?
0affc79
to
8cec32a
Compare
This change is intended to test for cycles in the deinflection definitions.
Currently this is a draft as it is incomplete, just a proof of concept.
Related: #438, #471