Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border styling options for structured content images #577

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Add border styling options for structured content images #577

merged 2 commits into from
Jan 27, 2024

Conversation

stephenmk
Copy link

I'd like to be able to style graphics with borders.

Without BorderWith Border

I tested this in Chromium and exported a test card to Anki (see the image below). Seems to work okay.

Test Anki card

anki

@stephenmk stephenmk requested a review from a team as a code owner January 25, 2024 03:38
Copy link

github-actions bot commented Jan 25, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@toasted-nutbread
Copy link

It might be worth simplifying the width/style/color declarations into the single border shorthand. Would simplify the values quite a bit and save on file size as well.

@djahandarie djahandarie added this pull request to the merge queue Jan 27, 2024
Merged via the queue into yomidevs:master with commit 1c258f7 Jan 27, 2024
5 checks passed
@stephenmk stephenmk deleted the image-border-radius branch January 27, 2024 15:18
@djahandarie djahandarie added the kind/enhancement The issue or PR is a new feature or request label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants