-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vitest benchmark #583
Add vitest benchmark #583
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
Very interesting, thanks! Maybe we could also consider using something like https://codspeed.io/blog/vitest-bench-performance-regressions ? (It seems to be free for OSS projects and looks more like the desired experience we would want on PRs. But I haven't looked at other potential solutions, it just came up from basic Google searching) |
Can you setup the action in the CI? |
@Scrub1492 I did the setup on the Codspeed side, and added the CODSPEED_TOKEN within our CI. Would you be able to add the contents of the action here: https://docs.codspeed.io/ci/github-actions to your PR? |
weird, it was working locally |
Does anyone have any idea what's breaking? not too familiar with github workflows 😅 |
Something from the CI logs. Based on this, if you get this working, we may want to do two things:
|
https://github.com/CodSpeedHQ/codspeed-node/tree/main/packages/vitest-plugin:
I believe this branch is still on vitest 1.1.1 because it's not on top of #612 |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
First step to #87 . Adds some benchmarks for high bandwidth functions.
However, vitest benchmark is still experimental, so not sure about maintainers' thoughts.