Fix auto hide search popup #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
previously approved these changes
Jan 31, 2024
toasted-nutbread
force-pushed
the
fix-auto-hide-search-popup
branch
from
de7b755
to
808bd38
Compare
toasted-nutbread
force-pushed
the
fix-auto-hide-search-popup
branch
from
808bd38
to
8247811
Compare
djahandarie
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580.
The issue was that the
_searchfunction wasn't invoked when there was no text source, which resulted in thesearchedevent never being invoked for that situation. This change happened during the type annotations conversion due to some confusion about how nulls should be handled.In this change, I've done a little bit of refactoring to make this less likely to occur. The
searchedevent has been split into three different events to clarify the intent:searchSuccess- happens when the search was successful and should have something displayed in the popup. This could be dictionary results, or the query parser.searchEmpty- no text source was present, or no search results were found.searchError- some error occurred.