Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all duplicate notes on click #636

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Show all duplicate notes on click #636

merged 8 commits into from
Feb 15, 2024

Conversation

eloyrobillard
Copy link

@eloyrobillard eloyrobillard commented Feb 4, 2024

Overview

This PR is to demonstrate a feature I had in mind in #610.

Now, when clicking the book icon in the pop-up, all duplicate Anki notes are shown (using 一括 as an example):

all notes get shown in the Anki browser

Areas of concern

The "view note(s)" button defaults to showing all notes1 in the browser, as opposed to only showing one card as it's done today.

Instead, the default behavior could be left unchanged, and we could add an option to "View all notes" inside the right-click context menu.

right-click context menu

Test Plan

Find a term with several duplicate notes in Anki

Book icon

  • Click the book icon for that term
  • All duplicate notes (within the selected scope) should be displayed in Anki

Context menu

  • Right-click the book icon
  • The IDs of all duplicate notes should appear
  • Click any such ID
  • Only the note corresponding to this ID should be displayed in Anki

"View Notes" Hotkey (Alt + V)

  • Use the "View Notes" hotkey on the selected term
  • All duplicate cards for this term should be displayed in Anki

Regression

  • All the above tests should work for a term with only a single note in Anki

Footnotes

  1. This works fine even if there is only one note in the list.

@eloyrobillard eloyrobillard marked this pull request as ready for review February 4, 2024 09:58
@eloyrobillard eloyrobillard requested a review from a team as a code owner February 4, 2024 09:58
@eloyrobillard eloyrobillard changed the title POC: Show all duplicate notes on click Show all duplicate notes on click Feb 4, 2024
@eloyrobillard eloyrobillard marked this pull request as draft February 4, 2024 10:03
Copy link

codspeed-hq bot commented Feb 4, 2024

CodSpeed Performance Report

Merging #636 will not alter performance

Comparing eloyrobillard:feature/display-all-duplicate-cards-on-click (6dc5458) with master (043ac79)

Summary

✅ 5 untouched benchmarks

Copy link

github-actions bot commented Feb 4, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@eloyrobillard eloyrobillard marked this pull request as ready for review February 7, 2024 06:15
ext/js/data/options-util.js Outdated Show resolved Hide resolved
ext/js/data/options-util.js Outdated Show resolved Hide resolved
@djahandarie djahandarie added this pull request to the merge queue Feb 15, 2024
Merged via the queue into yomidevs:master with commit 7a40962 Feb 15, 2024
7 of 8 checks passed
@eloyrobillard eloyrobillard deleted the feature/display-all-duplicate-cards-on-click branch February 15, 2024 17:25
@djahandarie djahandarie added the kind/enhancement The issue or PR is a new feature or request label Feb 25, 2024
@eloyrobillard eloyrobillard restored the feature/display-all-duplicate-cards-on-click branch April 16, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants