forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all duplicate notes on click #636
Merged
djahandarie
merged 8 commits into
yomidevs:master
from
eloyrobillard:feature/display-all-duplicate-cards-on-click
Feb 15, 2024
Merged
Show all duplicate notes on click #636
djahandarie
merged 8 commits into
yomidevs:master
from
eloyrobillard:feature/display-all-duplicate-cards-on-click
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloyrobillard
changed the title
POC: Show all duplicate notes on click
Show all duplicate notes on click
Feb 4, 2024
CodSpeed Performance ReportMerging #636 will not alter performanceComparing Summary
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
eloyrobillard
commented
Feb 8, 2024
toasted-nutbread
previously approved these changes
Feb 11, 2024
djahandarie
approved these changes
Feb 15, 2024
toasted-nutbread
approved these changes
Feb 15, 2024
eloyrobillard
deleted the
feature/display-all-duplicate-cards-on-click
branch
February 15, 2024 17:25
djahandarie
added
the
kind/enhancement
The issue or PR is a new feature or request
label
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to demonstrate a feature I had in mind in #610.
Now, when clicking the book icon in the pop-up, all duplicate Anki notes are shown (using 一括 as an example):
Areas of concern
The "view note(s)" button defaults to showing all notes1 in the browser, as opposed to only showing one card as it's done today.
Instead, the default behavior could be left unchanged, and we could add an option to "View all notes" inside the right-click context menu.
Test Plan
Find a term with several duplicate notes in Anki
Book icon
Context menu
"View Notes" Hotkey (Alt + V)
Regression
Footnotes
This works fine even if there is only one note in the list. ↩