Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unused HPA detection #22

Merged
merged 6 commits into from
Aug 9, 2023
Merged

feat: add unused HPA detection #22

merged 6 commits into from
Aug 9, 2023

Conversation

shay-legit
Copy link
Contributor

No description provided.

luisdavim
luisdavim reviewed Aug 9, 2023
View reviewed changes
pkg/kor/hpas.go Outdated Show resolved Hide resolved
@yonahd
Copy link
Owner

yonahd commented Aug 9, 2023

The HPA cmd should be supported in the all command as well.

luisdavim
luisdavim reviewed Aug 9, 2023
View reviewed changes
pkg/kor/hpas.go Outdated Show resolved Hide resolved
luisdavim
luisdavim reviewed Aug 9, 2023
View reviewed changes
pkg/kor/hpas.go Outdated Show resolved Hide resolved
@shay-legit
Copy link
Contributor Author

The HPA cmd should be supported in the all command as well.

good catch! works nicely.

image

yonahd
yonahd reviewed Aug 9, 2023
View reviewed changes
pkg/kor/hpas.go Outdated Show resolved Hide resolved
pkg/kor/all.go Outdated Show resolved Hide resolved
@shay-legit shay-legit marked this pull request as ready for review August 9, 2023 14:44
@yonahd
Copy link
Owner

yonahd commented Aug 9, 2023

Looking good!
Can you just sort your imports using
goimports -w .

@yonahd yonahd linked an issue Aug 9, 2023 that may be closed by this pull request
Support Hpa resource #14
Closed
yonahd
yonahd approved these changes Aug 9, 2023
View reviewed changes
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the contribution!

@yonahd yonahd merged commit 548c31f into yonahd:main Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdavim luisdavim luisdavim left review comments

@yonahd yonahd yonahd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Hpa resource
3 participants
@shay-legit @yonahd @luisdavim