Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 44 fixes #56

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Issue 44 fixes #56

merged 4 commits into from
Sep 5, 2023

Conversation

loaynaser3
Copy link
Contributor

No description provided.

yonahd
yonahd reviewed Sep 4, 2023
View reviewed changes
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great catches.
I put some ideas to improve the code here.

pkg/kor/deployments.go Outdated Show resolved Hide resolved
pkg/kor/deployments.go Outdated Show resolved Hide resolved
pkg/kor/deployments.go Outdated Show resolved Hide resolved
cmd/kor/deployments.go Outdated Show resolved Hide resolved
yonahd
yonahd approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonahd yonahd merged commit 0db197f into yonahd:main Sep 5, 2023
1 check passed
@loaynaser3 loaynaser3 mentioned this pull request Sep 5, 2023
Closed
@yonahd yonahd linked an issue Sep 5, 2023 that may be closed by this pull request
Support yaml format output #44
Closed
@chenrui333 chenrui333 mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonahd yonahd yonahd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support yaml format output
2 participants
@loaynaser3 @yonahd